[Cuis-dev] [FIX] Add class instance variables to classes sometimes fails

[Juan Vuletich]

Hi Gerald,

The test helps. Thanks.

Your initial changes recognize a broken data structure, and instead of 
trying to understand what caused the breakage, it just hides it under 
the carpet. That's why I asked for more info to reproduce and understand 
the problem.

Just pushed #5331. It fixes the root cause: When adding class ivars, the 
shape of subclasses was not updated. This is a serious bug! It is now 
fixed, and your test now passes.

Cheers,

On 6/29/2022 4:03 AM, Gerald Klix via Cuis-dev wrote:
> Hi Juan,
>
> I now wrote a test case with three tests,
> which I included.
> The good news: It fails.
> The bad news: It fails in a different manner.
> In this case I can not add a class instance variables
> to a subclass.
>
> I tested it on the following image versions:
>
> Haver 6.0
>   latest update: #5330
>
> Cuis 6.0
>   latest update: #5330
>
> ...
>
>
> HTH,
>
> Gerald
>
>
>
> On 6/29/22 06:51, Gerald Klix via Cuis-dev wrote:
>> Hi Juan,
>>
>> your prudence is justified.
>> My alleged “fix” isn't a fix in all cases.
>> Sorry, I was to hasty.
>>
>> I consider this issue crucial -- currently it blocks
>> me refactoring some code in an important project of mine --
>> there I will to write some testcases right now.
>>
>>
>> HTH,
>>
>> Gerald
>>
>>
>>
>> On 6/28/22 21:18, Juan Vuletich wrote:
>>> On 6/28/2022 9:42 AM, Gerald Klix via Cuis-dev wrote:
>>>> Hi all, Hi Juan,
>>>>
>>>> Yesterday night I discovered that adding class instance variables 
>>>> to a class with sub-classes (sometimes) fails in Haver.
>>>>
>>>> Alas this is not only an issue in Haver but also in
>>>> Cuis. Please find enclosed a fix for that issue.
>>>>
>>>>
>>>> HTH and Best Regards,
>>>>
>>>> Gerald
>>>
>>> Can you tell steps to reproduce? I'd like to understand the source 
>>> of the problem.
>>>
>>> Thanks,
>>>
>>
>


-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
https://independent.academia.edu/JuanVuletich
https://www.researchgate.net/profile/Juan-Vuletich
https://patents.justia.com/inventor/juan-manuel-vuletich
https://twitter.com/JuanVuletich