[Cuis-dev] Preference behavior and Parameters

[Luciano Notarfrancesco]

Very nice! Some comments and questions:

PreferenceNG class>>#detectType: is intended to be used for importing the
old preferences and will later be removed? I see it is inconsistent with
the initialization method that just sets type to 'aValue class' if aType is
nil. To ensure consistency, the initialization method could call
#detectType:, unless it's going to be removed. This is specially important
for Booleans, otherwise the preference will be stuck in true or false. And
should we set the type to the value class or species? Anyway, I'm not sure
it's a good idea to do this automatic detection of type, maybe it would be
better to just leave it in nil.

Also, PreferenceNG>>#printOn: capitalizes the name of the preference. Since
this name is used as a key to identify the preference, I think it's better
to show it as it is without capitalization.


On Thu, 5 May 2022 at 3:31 AM Hilaire Fernandes via Cuis-dev <
cuis-dev at lists.cuis.st> wrote:

> Hi,
>
> This is the third iteration of the class PreferencesNG.
>
> Most of the preferences/parameters found in Preferences/Preferences are
> implemented. There are a few exceptions like the "file list" operation,
> some behaviors could be implemented in the FileList.
>
> Regarding metrics: Preferences/Preference are 180 methods, 942 lines of
> code; PreferencesNG 42 methods, 402 lines of code.
>
> Hilaire
>
> --
> GNU Dr. Geohttp://drgeo.euhttp://blog.drgeo.eu
>
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st
> https://lists.cuis.st/mailman/listinfo/cuis-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20220505/2572a8a9/attachment-0001.htm>