[Cuis-dev] [FIX] Empty class categories crash the browser
Gerald Klix
cuis.01 at klix.ch
Mon Jul 31 12:53:35 PDT 2023
On 7/31/23 7:44 PM, Juan Vuletich via Cuis-dev wrote:
> On 7/31/2023 11:10 AM, Gerald Klix via Cuis-dev wrote:
>> On 7/31/23 3:49 PM, Gerald Klix via Cuis-dev wrote:
>>> On 7/31/23 2:16 PM, Juan Vuletich wrote:
>>>> On 7/31/2023 8:45 AM, Gerald Klix via Cuis-dev wrote:
>>>>> Hi all, Hi Juan,
>>>>>
>>>>> During testing I discovered, that I can
>>>>> define classes with an empty string as class category.
>>>>>
>>>>> Alas the class browser(s) will crash, when
>>>>> trying to display that empty category.
>>>>>
>>>>> Please find attached a fix for that issue.
>>>>>
>>>>>
>>>>> HTH and Best Regards,
>>>>>
>>>>> Gerald
>>>>
>>>> Hi Gerald,
>>>>
>>>> Thanks for finding this. I preferred a simpler approach, just call
>>>> it 'Uncategorized'. Update just pushed to GitHub.
>>>>
>>>> Thanks,
>>>>
>>> Juan, I don't like this!
>>> If I categorize something as '' I do not want to
>>> become magically re-categorized as something else.
>>>
>>> After all: «*Rose is a rose is a rose is a rose»
>>> *
>>> Quoted from:
>>> https://en.wikipedia.org/wiki/Rose_is_a_rose_is_a_rose_is_a_rose*
>>> *
>>>
>>> Just my 0.05€,
>>>
>>> Gerald*
>>> *
>>>
>>>
>> Besides: Lets define a package named "Uncategorized" and see what
>> happens: :}
>
> Well, the system never allowed for empty or nil class category. Now,
> it won't break. WRT the 'Uncategorized' name, I changed it to
> Categorizer default. Now it is consistent with uncategorized methods.
> I think that if anybody chooses that as a package name, they are
> masochists...
>
> Cheers,
>
I give up!
Please make sure that `SomeClass category: ''` leads to the same
result or patch the browser to cope with this the empty category.
Best Regards,
Gerald
More information about the Cuis-dev
mailing list