[Cuis-dev] [DEFECT] Can't zip Cuis' sources file

[Gerald Klix]

Thank's Juan,

this works now.

Alas when I tried to create a new Haver release I ran into another problem.
I also add strings to the ZIP-archive, for example a generated file that 
contains
all the contents of all the license files found. The resulting string 
contains
Unicode code-points, which makes the CRC computation fail.

In essence when sending #updateCrc:from:to:in: the primitive fails – for
obvious reasons – and the failure code kicks in. This in turn 
(indirectly) sends #bitXor:
to a UnicodePoint instance, which results in a DNU exception.

I will try to do some research on how UTF8 data is supposed
to be stored in a ZIP file.


Thank's again and Best Regards,

Gerald



On 11/21/23 9:12 PM, Juan Vuletich wrote:
> On 11/14/2023 10:20 AM, Gerald Klix via Cuis-dev wrote:
>> Hi all, Hi Juan,
>>
>> The following snippet does not terminate (within reasonable time, 20h):
>>
>> (z1 := ZipArchive new) zipFileComment: 'ZIP test'.
>> z1
>>     addFile: SourceFiles first fileEntry as: 'f1';
>>     writeToFileNamed: 'test.zip';
>>     close.
>>
>> Adding small test files, created like this: echo test > test.txt ,
>> however does work:
>>
>> (z3 := ZipArchive new) zipFileComment: 'ZIP test'.
>> z3
>>     addFile: Smalltalk imageName as: 'f3';
>>     writeToFileNamed: 'test.zip';
>>     close.
>>
>>
>>
>> Best Regards,
>>
>> Gerald
>
> Hi Gerald,
>
> I just pushed a fix to GitHub. Thanks for reporting.
>
> Cheers,
>