[Cuis-dev] Change List file in selections ignores method categorizations

[Bernhard Pieber]

Hi,

The attached test change set includes just a method recategorization. If I file it in using the install button in the FileList the method is recategorized.

However, if I use the contents button to open a ChangeList, select all changes and click file in selections it does not.

The reason seems to be that ChangeRecord>>#fileIn just ignores this type of changes, i.e. ChangeRecords of type #preamble followed by a #doit. When using install the recategorization is done in PositionableStream>>#compileNextChunkWhenStartsWithExclamationMark.

IMO it would be best to record method recategorizations differently in a ChangeSet. Currently, when a method gets recategorized the change is recorded as changeType #reorganize. When you save the ChangeSet the whole class organization is written to the ChangeSet file instead of just the changed method categorization. This has the effect that if you install two ChangeSets with independent method categorizations of the same class the second one will overwrite the first one.


Cheers,
Bernhard

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6351-CuisCore-BernhardPieber-2024May09-14h35m-bp.001.cs.st
Type: application/octet-stream
Size: 300 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20240509/23a7a3d7/attachment.obj>