[Cuis-dev] recent regression?

[Mark Volkmann]

Thanks! I definitely learned something new here. It had not occurred to me
that installing updates might break the functionality of open windows, but
it certainly makes sense. I suppose this is not common because I've never
encountered this in my 8 months or so of using Smalltalk.

On Fri, Nov 29, 2024 at 9:27 AM Juan Vuletich <juan at cuis.st> wrote:

>
> #buildMorphicSystemCategoryList is called when the Window is built... See
> senders. Names do mean something!!!
>
> Just close that Window and open a new one.
>
> On 11/29/2024 9:59 AM, Mark Volkmann via Cuis-dev wrote:
>
> That is because my screenshot is taken before I select "Changes ...
> Install New Updates".
> After I do that I see that line changes to "menuNshortcutsKey:
> #systemCatListMenuSpec;".
>
> But when I hover over the class category pane in a Browser and press cmd-f,
> I still get MessageNotUnderstood from the following expression in
> BrowserWindow
> because widgetKey is still set to #systemCategoriesListMenuSpec.
>
> (widgetKey numArgs = 0
>     ifTrue: [self perform: widgetKey]
>     ifFalse: [self perform: widgetKey with: aWidget]) do: aBlock.
>
> Could the problem be that installing the changes doesn't update the
> shortcut keys which have already been initialized,
> so they still are set to use the old value for that widgetKey?
> Is there something I need to do to rerun some setup code after installing
> new updates?
>
> On Fri, Nov 29, 2024 at 8:38 AM Juan Vuletich <juan at cuis.st> wrote:
>
>> On 11/29/2024 9:14 AM, Mark Volkmann wrote:
>>
>> I cloned Cuis-Smalltalk-Dev again and was able to reproduce the issue.
>> It seems that the commit that causes the issue for me is f1ff80b.
>> See lines 159-160 in the file CoreUpdates/
>> 6844-BetterSelectors-JuanVuletich-2024Nov22-15h28m-jmv.001.cs.st.
>> These remove the systemCategoriesListMenuSpec method.
>> With the commit before that which is 5f45738 I cannot reproduce the
>> issue.
>>
>> I think you are correct that there are no direct senders of
>> #systemCategoriesListMenuSpec.
>> But there is a "self perform: widgetKey" where widgetKey gets set
>> to #systemCategoriesListMenuSpec in SystemWindow.
>> See the attached screenshots.
>>
>>
>> But #6844 also includes a redefinition of #buildMorphicSystemCategoryList
>> dated 11/22/2024 15:29:47 that fixes exactly that, and that seems missing
>> from your screenshot.
>>
>>
>>
>> On Fri, Nov 29, 2024 at 6:15 AM Juan Vuletich <juan at cuis.st> wrote:
>>
>>> On 11/28/2024 5:29 PM, Mark Volkmann via Cuis-dev wrote:
>>>
>>> Perhaps there was a recent regression. I get the error
>>> "MessageNotUnderstood BrowserWindow>>systemCategoriesListMenuSpec" when I
>>> follow these steps:
>>>
>>> 1. Start the base image Cuis7.1-6770.image
>>> 2. Click on the World.
>>> 3. Select Changes ... Install New Updates.
>>> 4. Open a Browser.
>>> 5. Hover over the class categories pane.
>>> 6. Press cmd-f (in macOS).
>>>
>>> --
>>> R. Mark Volkmann
>>> Object Computing, Inc.
>>>
>>>
>>> Hi Mark,
>>>
>>> #systemCategoriesListMenuSpec has no senders in an updated stock image.
>>> Something is funky on your setup.
>>>
>>> HTH,
>>>
>>> --
>>> Juan Vuletichcuis.stgithub.com/jvuletichresearchgate.net/profile/Juan-Vuletichindependent.academia.edu/JuanVuletichpatents.justia.com/inventor/juan-manuel-vuletichlinkedin.com/in/juan-vuletich-75611b3twitter.com/JuanVuletich
>>>
>>>
>>
>> --
>> R. Mark Volkmann
>> Object Computing, Inc.
>>
>>
>>
>> --
>> Juan Vuletichcuis.stgithub.com/jvuletichresearchgate.net/profile/Juan-Vuletichindependent.academia.edu/JuanVuletichpatents.justia.com/inventor/juan-manuel-vuletichlinkedin.com/in/juan-vuletich-75611b3twitter.com/JuanVuletich
>>
>>
>
> --
> R. Mark Volkmann
> Object Computing, Inc.
>
>
>
> --
> Juan Vuletichcuis.stgithub.com/jvuletichresearchgate.net/profile/Juan-Vuletichindependent.academia.edu/JuanVuletichpatents.justia.com/inventor/juan-manuel-vuletichlinkedin.com/in/juan-vuletich-75611b3twitter.com/JuanVuletich
>
>

-- 
R. Mark Volkmann
Object Computing, Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20241129/e80acc90/attachment.htm>