[Cuis-dev] possible issue in Network-Kernel package

[Juan Vuletich]

Hi Mark,

It was me last night. While fixing #matchStart: I broke #upToall:.

Thank you very much for tracking it down! You pointed exactly to the 
source of the problem. That made it easy to fix.

I just pushed a fix to GitHub, together with a test.

Apologies for the inconvenience.

On 10/28/2024 9:52 PM, Mark Volkmann via Cuis-dev wrote:
> The error seems to be in this code:
>
> (scheme = 'http' or:[scheme = 'https'])
>     ifFalse:[self error: 'Unsupported scheme: ', scheme].
>
> If I comment that out, all the tests pass again.
>
> The scheme variable is set with this line:
>
>  scheme := (urlStream upToAll: '://') asLowercase.
>
> I wonder if the upToAll: method changed recently.
> I see that there have been several commits to the Network-Kernel 
> package recently.
> The WebClient package also implements the upToAll: method.
>
> On Mon, Oct 28, 2024 at 8:40 PM Mark Volkmann 
> <r.mark.volkmann at gmail.com <mailto:r.mark.volkmann at gmail.com>> wrote:
>
>     The error comes from the WebClient method initializeFromUrl.
>     That method checks that the value of the scheme variable is either
>     'http' or 'https'.
>     But the value is 'http:' with a colon.
>     Perhaps something changed with the way the scheme is extracted
>     from URLs.
>     I'll keep digging.
>
>     On Mon, Oct 28, 2024 at 8:36 PM Mark Volkmann
>     <r.mark.volkmann at gmail.com <mailto:r.mark.volkmann at gmail.com>> wrote:
>
>         After pulling the latest on Cuis-Smalltalk-Dev, launching the
>         base image, and selecting "Changes ... Install New Updates"
>         from the World menu, I'm getting an error that says
>         "Unsupported scheme: http" when I run the unit tests in my
>         WebClientPlus package. I haven't been able to track down the
>         cause yet, but I can explain how to reproduce it.
>
>         1. git clone
>         https://github.com/mvolkmann/Cuis-Smalltalk-WebClientPlus.git
>         2. Start the base image Cuis7.1-6770.image.
>         3. Do not "Install New Updates".
>         4. Evaluate "Feature require: 'WebClientPlus'." in a Workspace.
>         5. Open an SUnit Test Runner window.
>         6. Select "DogWebServerTests" and click the Run button.
>         7. Note that all the tests pass.
>         8. Open the World menu and select "Changes ... Install New
>         Updates".
>         9. Run the tests again and note that they all fail with the
>         error "Unsupported scheme: http:"
>
>         I'll keep trying to track this down, but I wanted to share
>         this in case someone recognizes this error and knows how to
>         fix it.
>
>         -- 
>         R. Mark Volkmann
>         Object Computing, Inc.
>
>
>
>     -- 
>     R. Mark Volkmann
>     Object Computing, Inc.
>
>
>
> -- 
> R. Mark Volkmann
> Object Computing, Inc.


-- 
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20241029/bb1f46a9/attachment.htm>