[Cuis-dev] [Fix] Small fixes to SystemWindow

[Juan Vuletich]

Hi Nico,

On 1/10/2025 5:26 PM, Nicolás Papagna Maldonado via Cuis-dev wrote:
> Hi folks!
>
> While investigating the SystemWindow hierarchy, I found that the 
> #open:label message sends #buildMorphicWindow but that method is not 
> defined on the instance side.
> This signals a MNU error instead of a subclass responsibility one.

It is not clear that any subclass should implement that method. For 
subclasses that don't use a model and don't have #buildMorphicWindow, 
#open:label: would not be appropriate, but that doesn't mean they should 
implement it anyway. The current behavior suggest the developer that 
they need to decide what to do.

> I also extracted #toOpen: from #open:label: because I didn't find a 
> way to create a properly initialized SystemWindow (model + the call to 
> #buildMorphicWindow) without
> opening it in the world.

I don't think that is generally useful enough. Senders using 
SystemWindow in unusual ways can inline those two message sends in their 
own code.

>
> The attached changeset addresses both.
>
> Cheers,
> Nico

Thanks,

-- 
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich