[Cuis-dev] Refactoring proposal for Browser>>classList

[Juan Vuletich]

Hi Facu,

Wow! This is Amazing!

This is exactly the approach I take when doing such complex 
refactorings. I reviewed all the changes, and being them so well 
structured, and accompanied by the detailed document, it was not difficult.

Actually, when I review larger contributions, I tend to do this same 
decomposition myself, trying to understand which changes go together, 
sometimes splitting them in a sequence of files. Not only you saved me 
hours of work, but you also made the integration possible. If all these 
changes came together in one changeset, I doubt I would have been able 
to untangle them in order to understand them.

The only minimal tweak I did was to include your remark at 9. in the 
method comment, for future reference.

WRT the the additional 10. change set, I think this could perhaps could 
go as part of an optional Theme. It should be done with straight SVG or 
SVG converted to vector graphics drawing Smalltalk code, etc. It could 
be part of an optional package with visual enhancements. Food for thought.

Thank you very much for this. Today I'm a happy code reviewer and 
project maintainer.

Folks, consider this the gold standard for the style of contributions 
for the Cuis base image.

Cheers,

On 2026-04-28 9:52 PM, Facundo Javier Gelatti via Cuis-dev wrote:
> Hello!
>
> I've been doing some refactoring work on the Browser, to improve the 
> separation between content and presentation in the visualization of 
> the items on the parallel packages/classes/protocols/methods 
> lists. The attached changes modify the logic for the class list. I'm 
> working on similar changes for the message categories and methods list.
>
> One thing that is challenging is how to make changes like this one 
> easier to review, since they involve many modifications. So, I broke 
> up the change into a progression of small changes, so that each could 
> be reviewed in sequence. Also, if we decide not to integrate them all, 
> we could still merge a subset. I also included a document with 
> additional descriptions to be used while reviewing the code.
>
> I hope you like the proposed changes, and that the way I chose to 
> split them is useful during the review!
>
> Cheers!
> Facu
>
>
-- 
Juan Vuletich
www.cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich