[Cuis-dev] Missing method SHTextStylerST80>>convertedAndStyledText

[Juan Vuletich]

Hi Bernhard,

I checked the update #7721. At that point, in the base image, the object 
stored in the 'formattedText' instance variable didn't change during 
formatting (it is still that way). So there was no need to ask for it 
again. The other two methods changed in #7721 were modified not to call 
#convertedAndStyledText.

Do you think it is still needed for StyledTextEditor? Reintroducing it 
will make styling in STE work ok?

Thanks,

On 2026-09-22 6:07 PM, Bernhard Pieber via Cuis-dev wrote:
> Hi,
>
> StyledTextEditor calls the method convertedAndStyledText on 
> SHTextStylerST80 which does not exist in the latest image anymore.
>
> It was easy to find out it was removed in 
> 7721-Cleanup-JuanVuletich-2025Nov28-07h39m-jmv.001.cs.st 
> <http://7721-Cleanup-JuanVuletich-2025Nov28-07h39m-jmv.001.cs.st>:
> grep convertedAndStyledText CoreUpdates/*
>
> However, neither the changes nor the sources file contain the original 
> method:
> Cuis-Smalltalk-Dev % grep convertedAndStyledText 
> CuisImage/Cuis7.9-8206.changes
> Cuis-Smalltalk-Dev % grep convertedAndStyledText 
> CuisImage/Cuis7.8.sources
> Cuis-Smalltalk-Dev %
>
> With the following git command I was able to find the source code of 
> the original method:
> git log -G"convertedAndStyledText" -p -- CuisImage/Cuis*.sources | 
> grep -B 1 -A 15 "^\+\s*convertedAndStyledText"
>
> !SHTextStyler methodsFor: 'accessing' stamp: 'jmv 4/3/2023 15:43:28'!
>                    convertedAndStyledText
> ^ formattedText! !
>
> It just returns the instance variable formattedText.
>
> Should we reintroduce the method convertedAndStyledText or add the 
> accessor formattedText and change the call in StyledTextEditor to use 
> the latter instead of convertedAndStyledText?
>
> If the former should we use the original stamp 'jmv 4/3/2023 15:43:28' 
> or a new one?
>
> Opinions?
>
> Cheers,
> Bernhard
>
>
>
>
>
-- 
Juan Vuletich
www.cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20260923/81235d09/attachment.htm>