[Cuis-dev] allSubclasses and withAllSubclasses improvement

[Juan Vuletich]

Wow, thanks. The old code was slow and ugly!

Integrating it.

Cheers,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich


On 8/21/2019 9:26 AM, Hernan Wilkinson via Cuis-dev wrote:
> Hi,
>  attached is a cs that changes the implementation of #allSubclasses 
> and #withAllSubclasses and generates performance improvement drastically.
>  Just as a quick example, with the current implementation:
>  Time millisecondsToRun: [ 100 timesRepeat: [Behavior 
> withAllSubclasses ]] 1140 .
>  With the proposed change:
>  Time millisecondsToRun: [ 100 timesRepeat: [Behavior 
> withAllSubclasses2 ]]  . 73
>
>  In the type checker of LiveTyping, checking Behavior goes from 9.5 
> seconds to 5 seconds only with that change.
>  One difference between the current and proposed version, is that the 
> current returns a Set while the proposed version returns an 
> OrderedCollection.
>  I looked carefully if that could break something and it does not. 
> I've been using the image with this new implementation and everything 
> works fine.
>
>  Juan, please take a look at it and integrate it if you think it is 
> useful.
>  Hernan.
>
> -- 
> *Hernán Wilkinson
> Agile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20190821/96d57544/attachment.htm>