[Cuis-dev] SmalltalkEditor inserts notification at wrong position

[Hernan Wilkinson]

👍

On Fri, May 31, 2019 at 12:01 PM Luciano Notarfrancesco <luchiano at gmail.com>
wrote:

> Hi Hernan,
> I did it by selecting the variable name in the browser editor and then
> cmd+R. I had two instance variables, I tried to rename one and it renamed
> the other one, then I tried to rename it back and again renamed the wrong
> one, then I fixed it manually. But I can't reproduce it now. I'll try to
> use cmd-R more often and I'll let you know if it happens again.
>
> Thanks!
> Luciano
>
> On Fri, May 31, 2019 at 2:11 PM Hernan Wilkinson <
> hernan.wilkinson at 10pines.com> wrote:
>
>> Hi Luciano,
>>  could you tell me how you tried to rename the instance variable? It is
>> working correctly for me... maybe you are assuming something from the UI
>> point of view that is not correct...
>>  There are two ways to rename an inst var:
>> 1) Right click on the selected class in the browser and select
>> "Refactorings" and then "Rename inst. var...". If you do this it will ask
>> you the inst var to rename
>> 2) In the browser editor put the cursor in an inst var and press cmd+R,
>> it should rename that inst var with the new name
>>
>> Let me know how you are doing it to see what the problem is
>>
>> Hernan.
>>
>> On Fri, May 31, 2019 at 12:44 AM Luciano Notarfrancesco via Cuis-dev <
>> cuis-dev at lists.cuis.st> wrote:
>>
>>> If the compilation of a selection fails in a workspace or a browser or
>>> any SmalltalkEditor when doing doIt/printIt/etc, the error message is
>>> inserted relative to the start of the whole text, not relative to the start
>>> of the selection.
>>>
>>> Didn't look much into it yet, and I'm not sure what's the best way to
>>> fix it. The problem is that the compiler calls
>>> SmalltalkEditor>>notify:at:in: and here you don't know if the error comes
>>> from saving a method in a browser (in this case it should be inserted
>>> relative to the start of the whole text) or from a doIt (relative to the
>>> start of the selection).
>>>
>>> Two other bugs I saw and still didn't spend time trying to fix them:
>>> - sometimes the selected text in the debugger is wrong, it doesn't mark
>>> the position of the instruction pointer correctly;
>>> - I tried the refactoring to rename instance variables and it renamed
>>> the wrong variable, not the one selected.
>>> --
>>> Cuis-dev mailing list
>>> Cuis-dev at lists.cuis.st
>>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>>
>>
>>
>> --
>>
>> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
>> *Phone: +54-011*-4893-2057
>> *Twitter: @HernanWilkinson*
>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>
>

-- 

*Hernán WilkinsonAgile Software Development, Teaching & Coaching*
*Phone: +54-011*-4893-2057
*Twitter: @HernanWilkinson*
*site: http://www.10Pines.com <http://www.10pines.com/>*
Address: Alem 896, Floor 6, Buenos Aires, Argentina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20190531/e932b6c4/attachment-0001.html>