[Cuis-dev] Changes refactoring - Part 2

[Juan Vuletich]

On 10/27/2019 12:05 AM, Hernan Wilkinson via Cuis-dev wrote:
> Hi,
>  attached are two more refactorings of the changes model
>
> Cheers!
> Hernan.
>
> -- 
> *Hernán Wilkinson
> Agile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina

Hi Hernán,

I just reviewed the changes. These are very good additions, and complete 
quite a bit our changes model.

Still I have a couple of comments / questions:

1) In #classDefinitionRecordFrom: the category is retrieved from 'tokens 
last' even if the call to #stampFrom: means that the method should 
handle a possible stamp. I guess a method #categoryFrom: , similar to 
#stampFrom: is in order, right?

2) In #stampFrom: I suggest making the last line read "^ stamp ifNil: [ 
'' ]", so we can review changes like your #3930 (already loaded) without 
a walkback.

3) After loading this changes, an evaluation of "ClassOrganizer 
allInstancesDo: [:co | co removeEmptyCategories]." is in order.

4) Maybe not related to all these, but 
#test03SuiteForNoTestCaseClassAndNoTestClassLooksForReferencesInTests 
fails because Object testCaseClass = ObjectTest (even if unrelated I 
believe you wrote both the failing test and ObjectTest class).

Cheers,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20191028/bcc6a3e7/attachment.htm>