[Cuis-dev] Latest updates break method timestamps and versions

[Phil B]

Juan,

Sorry for the delay in responding... been busy the past few days.  That
looks like it resolved the issue.

Thanks,
Phil

On Thu, Apr 2, 2020 at 2:51 PM Juan Vuletich <juan at jvuletich.org> wrote:

> Fix now at GitHub. Please try again now. Hernán, I moved some of the
> services you added, from FileList to CompiledMethod class, so they are
> usable by anyone.
>
> Thanks,
>
> --
> Juan Vuletichwww.cuis-smalltalk.orghttps://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Devhttps://github.com/jvuletichhttps://www.linkedin.com/in/juan-vuletich-75611b3
> @JuanVuletich
>
>
> On 4/2/2020 1:16 PM, Juan Vuletich via Cuis-dev wrote:
>
> Thanks Phil. I can see the problem. This requires some refactoring to
> unify code between CompiledMethod and FileList. I'll post a fix today.
>
> Cheers,
>
> --
> Juan Vuletichwww.cuis-smalltalk.orghttps://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Devhttps://github.com/jvuletichhttps://www.linkedin.com/in/juan-vuletich-75611b3
> @JuanVuletich
>
>
> On 4/2/2020 4:56 AM, Phil B via Cuis-dev wrote:
>
> Let me know if this allows you to reproduce (i.e. I've got it reproducible
> with what I believe is a good, vanilla base image):
>
> 1) git clone https://github.com/pbella/broken4099
> 2) cd broken4099
> 3) copy your CuisV5.sources into the directory and start the image
> 4) in the currently highlighted method (String>>#+) just add a space and
> delete it. (i.e. force a change to the source)
> 5) save the method providing initials when prompted
>
> You should now see the timestamp for the method has been wiped (i.e. 'no
> timeStamp') and if you browse versions of the method there is no history.
> However, if you fileOut the method the correct author and timestamp is
> there.  This issue should now occur with most, but not all, methods.  See
> my repo commit comment re: quickly browsing just the changes that are the
> likely culprits (i.e. since 4069.)
>
> On Thu, Apr 2, 2020 at 3:19 AM Phil B <pbpublist at gmail.com> wrote:
>
>> Well that wasn't it... it's back.  So I'll start digging through the
>> changesets to see if I've got a brittle override that needs to be changed
>> or if the changes themselves broke something...
>>
>> On Tue, Mar 31, 2020 at 3:55 PM Hernan Wilkinson <
>> hernan.wilkinson at 10pines.com> wrote:
>>
>>> ok... let's hope it was that :-)
>>>
>>> On Tue, Mar 31, 2020 at 1:38 PM Phil B <pbpublist at gmail.com> wrote:
>>>
>>>> Hmm... looks like my base image picked up (what I assume to be) a
>>>> single-bit error recently.  (i.e. subtle as hell weirdness that's
>>>> impossible to reproduce in anyone else's image) I went back to 4024 and
>>>> reapplied all updates and the problem was resolved.  This may also explain
>>>> why I had problems with Juan's recent font work.
>>>>
>>>> C'mon AMD, hurry up with that next gen Ryzen...
>>>>
>>>> On Tue, Mar 31, 2020 at 7:33 AM Hernan Wilkinson <
>>>> hernan.wilkinson at 10pines.com> wrote:
>>>>
>>>>> Hi Phil,
>>>>>  could you give me more info about what you are doing? which method
>>>>> you are modifying, the steps you are making, etc., because I can not
>>>>> reproduce it here.
>>>>>
>>>>>  Thanks!
>>>>>  Hernan.
>>>>>
>>>>> On Tue, Mar 31, 2020 at 4:53 AM Phil B via Cuis-dev <
>>>>> cuis-dev at lists.cuis.st> wrote:
>>>>>
>>>>>> Just to clarify: the changes are still there, they just aren't
>>>>>> visible via Browser windows.  Recent changes shows them, package browser
>>>>>> shows them and if I save a modified package the timestamps look correct.
>>>>>>
>>>>>> On Tue, Mar 31, 2020 at 3:07 AM Phil B <pbpublist at gmail.com> wrote:
>>>>>>
>>>>>>> When I open a 4097 image and change any method in the browser, the
>>>>>>> author/timestamp gets wiped and method versions disappear.  Timestamps and
>>>>>>> versions from loaded packages are still intact so it looks like a code
>>>>>>> editor issue? (this occurred somewhere after 4069)
>>>>>>>
>>>>>> --
>>>>>> Cuis-dev mailing list
>>>>>> Cuis-dev at lists.cuis.st
>>>>>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> *Hernán Wilkinson Agile Software Development, Teaching & Coaching*
>>>>> *Phone: +54-011*-4893-2057
>>>>> *Twitter: @HernanWilkinson*
>>>>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>>>>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>>>>
>>>>
>>>
>>> --
>>>
>>> *Hernán Wilkinson Agile Software Development, Teaching & Coaching*
>>> *Phone: +54-011*-4893-2057
>>> *Twitter: @HernanWilkinson*
>>> *site: http://www.10Pines.com <http://www.10pines.com/>*
>>> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200407/b4ea93f3/attachment.htm>