[Cuis-dev] findSelector fixes

[Juan Vuletich]

Hi Hernán,

On 12/29/2020 1:34 PM, Hernan Wilkinson via Cuis-dev wrote:
> Hi,
>  String>>#findSelector failed when the string has an unmatched double 
> quote, for example:
>  '"self m:' findSelector --> signals error
>  Also, it did not support when looking inside a comment, which is very 
> common to do when a method has an example as a comment.
>
>  Attached is a fix for that case and also a test for it.

Integrated. Thanks!

>
> @Juan Vuletich <mailto:juan at jvuletich.org> Do you know why 
> findSelector was doing this check?
> "and: [ (self at: colonIndex - 1) isLetter ]"
> Why is it checking for isLetter? and btw, the check was wrong because 
> it was sending #at: to self instead of to sel.

That was added as part of 
3525-MiscFixesForColonAsBinarySelector-JuanVuletich-2018Dec14-13h29m-jmv.1.cs.st 
. I guess it is still needded. So I added it back (fixing the receiver).

> I removed that check because I could not find a reason for it
>
> Cheers!
> Hernan.
>
> -- 
> *Hernán Wilkinson
> Agile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina

Thanks,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20201229/27ffa70e/attachment.htm>