[Cuis-dev] FileList annoyance

[Phil B]

Pull request submitted (there are a couple of impacted core packages)  As
always, ignore all the commits (that's just me keeping in sync with the
main repo) and look at the diffs.

Thanks,
Phil

On Wed, Feb 26, 2020 at 9:43 AM Juan Vuletich via Cuis-dev <
cuis-dev at lists.cuis.st> wrote:

> Hi Phil,
>
> Feel free to replace Strings with FileEntries anywhere. It will be a
> great contribution. Those Strings are leftovers from before FileEntry.
>
> I'm sure there are plenty of places in need of cleanup. As we can't
> schedule anyone the task of cleaning up the system, we do it in small
> unplanned steps, anytime we find an annoyance and feel like cleaning it.
>
> On 2/25/2020 5:46 AM, Phil B via Cuis-dev wrote:
> > Here's something I've been meaning to fix for a while now: we have
> > FileList and the related #fileReaderServicesForFile:suffix: methods
> > (and in turn the methods they point to) which almost all have 'File'
> > in their name but then proceed to take and expect a string filename
> > rather than a FileEntry.  Would there be any objection to a changeset
> > that renames the vague *File* method names to *FileEntry* and actually
> > passes around FileEntry rather than String instances?  If anyone has a
> > problem with that and wants to keep using strings, then how about we
> > at least rename these methods from *File* to *Filename*?
>
> Thanks,
>
> --
> Juan Vuletich
> www.cuis-smalltalk.org
> https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
> https://github.com/jvuletich
> https://www.linkedin.com/in/juan-vuletich-75611b3
> @JuanVuletich
>
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st
> https://lists.cuis.st/mailman/listinfo/cuis-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200226/d82e7ee3/attachment-0001.htm>