[Cuis-dev] Flaky test fix + addon to analyze possible flaky tests

Hernan Wilkinson hernan.wilkinson at 10pines.com
Sun Mar 8 13:21:50 PDT 2020


Hi Nahuel,
 while integrating your change the name of the message
#criteriaToSortSourceRangeBetween:and: sound wired to me because it does
not answer a criteria but it does the comparison... I think the name
#is:afterOrSmallerTo: may be a better name... what do you think?
 Also, this kind of mistake is very often, it happened a lot of times to me
and that made me thought if those kind of comparison shouldn't be part of
the Interval protocol. I have the feeling that there are a couple of those
comparisons between Intervals scattered around the code...
 What do you people think? Does it make sense to put messages in Interval
to compare if an interval is before or after another?

Cheers!
Hernan.

On Sun, Mar 8, 2020 at 6:28 AM Hernan Wilkinson <
hernan.wilkinson at 10pines.com> wrote:

> Hi Nahuel!
>  thank you for the fix. It is in github now.
>  Regarding the package, I think it is a nice tool to have, I would add it
> to the repo.
>  What do the rest of the group think?
>
> Hernan.
>
> On Sat, Mar 7, 2020 at 8:24 PM Nahuel Garbezza via Cuis-dev <
> cuis-dev at lists.cuis.st> wrote:
>
>> Hi!
>>
>> As it was mentioned in the list, the Cuis-Smalltalk-Dev build was broken
>> on CI, and one of the causes was a test that I introduced about the
>> ExtractMethod refactoring.
>>
>> There was not a problem with the test, but with the refactoring
>> implementation itself. Attached is a changeset to fix the underlying issue
>> with the refactoring that was causing the test to fail sometimes.
>>
>> And because this is Smalltalk and it is super fun, I created a very
>> simple package called "FlakyTestsDetector", which contains a very simple
>> class that runs a test multiple times, reports the results and can help you
>> to detect if a test is flaky or not and how many times it failed (from the
>> number of times it was executed). Attached is the package, let me know if
>> you feel this is "helpful enough" to include it on the repo :)
>>
>> Thanks!
>> Nahuel.
>> --
>> Cuis-dev mailing list
>> Cuis-dev at lists.cuis.st
>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>
>
>
> --
>
> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>


-- 

*Hernán WilkinsonAgile Software Development, Teaching & Coaching*
*Phone: +54-011*-4893-2057
*Twitter: @HernanWilkinson*
*site: http://www.10Pines.com <http://www.10pines.com/>*
Address: Alem 896, Floor 6, Buenos Aires, Argentina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200308/2316bccb/attachment.htm>


More information about the Cuis-dev mailing list