[Cuis-dev] Flaky test fix + addon to analyze possible flaky tests
Juan Vuletich
juan at jvuletich.org
Mon Mar 9 12:18:21 PDT 2020
Something like this?
intervalA last < intervalB first -> A comes before B
intervalA first > intervalB last -> A comes after B
(intervalA first < intervalB first) and (intervalA last > intervalB
last) -> A includes B
(intervalA first > intervalB first) and (intervalA last < intervalB
last) -> B includes A
(intervalA first < intervalB first) and (intervalB first < intervalA
last < intervalB last) -> A partially before B
(intervalA first > intervalB first) and (intervalA first < intervalB
last < intervalA last) -> A partially after B
Cheers,
On 3/8/2020 5:21 PM, Hernan Wilkinson via Cuis-dev wrote:
> Hi Nahuel,
> while integrating your change the name of the message
> #criteriaToSortSourceRangeBetween:and: sound wired to me because it
> does not answer a criteria but it does the comparison... I think the
> name #is:afterOrSmallerTo: may be a better name... what do you think?
> Also, this kind of mistake is very often, it happened a lot of times
> to me and that made me thought if those kind of comparison shouldn't
> be part of the Interval protocol. I have the feeling that there are a
> couple of those comparisons between Intervals scattered around the
> code...
> What do you people think? Does it make sense to put messages in
> Interval to compare if an interval is before or after another?
>
> Cheers!
> Hernan.
>
> On Sun, Mar 8, 2020 at 6:28 AM Hernan Wilkinson
> <hernan.wilkinson at 10pines.com <mailto:hernan.wilkinson at 10pines.com>>
> wrote:
>
> Hi Nahuel!
> thank you for the fix. It is in github now.
> Regarding the package, I think it is a nice tool to have, I would
> add it to the repo.
> What do the rest of the group think?
>
> Hernan.
>
> On Sat, Mar 7, 2020 at 8:24 PM Nahuel Garbezza via Cuis-dev
> <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>> wrote:
>
> Hi!
>
> As it was mentioned in the list, the Cuis-Smalltalk-Dev build
> was broken on CI, and one of the causes was a test that I
> introduced about the ExtractMethod refactoring.
>
> There was not a problem with the test, but with the
> refactoring implementation itself. Attached is a changeset to
> fix the underlying issue with the refactoring that was causing
> the test to fail sometimes.
>
> And because this is Smalltalk and it is super fun, I created a
> very simple package called "FlakyTestsDetector", which
> contains a very simple class that runs a test multiple times,
> reports the results and can help you to detect if a test is
> flaky or not and how many times it failed (from the number of
> times it was executed). Attached is the package, let me know
> if you feel this is "helpful enough" to include it on the repo :)
>
> Thanks!
> Nahuel.
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
> https://lists.cuis.st/mailman/listinfo/cuis-dev
>
>
>
> --
> *Hernán Wilkinson
> Agile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina
>
>
>
> --
> *Hernán Wilkinson
> Agile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina
--
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200309/488ad449/attachment.htm>
More information about the Cuis-dev
mailing list