[Cuis-dev] Replacing FillInTheBlankMorph
Juan Vuletich
juan at jvuletich.org
Sat May 23 17:05:38 PDT 2020
On 5/21/2020 5:48 PM, Luciano Notarfrancesco via Cuis-dev wrote:
> I've been using this for a couple of days and here's a new version
> with two bugs fixed.
>
> On Wed, May 20, 2020 at 7:00 PM Luciano Notarfrancesco
> <luchiano at gmail.com <mailto:luchiano at gmail.com>> wrote:
>
> This change set replaces FillInTheBlankMorph with a new
> StringRequestMorph, and fixes the great majority of uses in the
> image to be not modal. It was tedious work, and sadly there were a
> few methods that I couldn't fix, so I included messages
> #request:initialAnswer: and #request:initialAnswer:orCancel: that
> do the modal thing... if people agree we could consider them
> deprecated and try to fix the few senders and delete them.
>
> Let me know what you think. And help me test it, please. Some of
> the changes are not completely trivial, for example I had to
> rewrite some code in order to avoid doing ^self in the handler block.
>
> Thanks,
> Luciano
>
This is great Luciano!
This is integrated and at GitHub. Just a couple of tweaks:
- I didn't remove FillInTheBlanksMorph. Many packages still use it.
- I removed the references to Morphic from Object, with a hopefully
cleaner way.
Thanks!
--
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200523/12c26025/attachment.htm>
More information about the Cuis-dev
mailing list