[Cuis-dev] For Test: Layouts + EdgeWeight

[Juan Vuletich]

Hi Ken,

On 5/26/2020 5:28 PM, ken.dickey--- via Cuis-dev wrote:
> On 2020-05-26 15:13, Juan Vuletich wrote:
>> This is impressive!
>
> Be less impressed until you test a bit. ;^)
>

I have my hopes high, even if still had some trouble.

>> I just tried cloning https://github.com/KenDickey/LayoutProposal
>
> Do an update (again).
>
> Open a FileList on LayoutProposal/LayoutTestWithEdgeWeights.txt
>
> Select all text and DoIt.
>
> You should be able to play around now (modulo pathname prefix 
> adjustment).

Ok. If I do it exactly like that, it works. But if I just load the 
#4187, without having Morphic-Misc1, the problem is that 
#privateProportionalWidth is called but not implemented. Can you please 
move this method out of Morphic-Misc1, and into #4187? Also, please 
check if any other such changes might be needed.

>
> I included Morphic-Misc1 to have easy Layout{Morph/Spec} editing from 
> Morph Menus, but is not required.
>
> Other unsaved change sets are for testing various other unneeded 
> packages but use new EdgeWeights.
>
> Note that I removed #padding #padding: #minorDirection* for test.  We 
> could certainly retain these for a period to let people transition to 
> {axis/offAxis}EdgeWeight over time.

Sure.

>> 2- It seems you removed #submorphsToLayout.
>
> That should be there.

Oh, my bad. I see it now. Thanks.

>> I think we'd test a bit your proposal, and integrate it.
>
> That is the correct order!  :)
>
>
> Hope you like it.  Just today I had a chance to simplify the layout 
> code to be less Pascal and more Smalltalk.
>
> Let me know!
> -KenD

Very nice. Thanks again for this new Layout implementation!

Cheers,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich