[Cuis-dev] Updates for Theme, etc

[Casey Ransberger]

Found time to do the refactor today. Decoupling the Taskbar will have to wait a bit longer, as I’m out of time for now, but I expect that to be straightforward. The attached code is ready for review.

Note for the integrator: this stuff touches a bunch of UI. Nothing blows up on my machine har har har! But best to back up your work before bringing in this code, as if I have a bug somewhere, you know, images might explode (usually a million debuggers will open if that’s the case.)

I think on balance that this is a lot nicer than what was there before. Let me know what y’all think. As planned, it removes a bunch of code duplication and send sites, and adds a class with a small selection of entirely trivial methods. These changes shouldn’t affect observed behavior outside of perhaps an insignificant reduction in latency when opening new windows.

—Casey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4192-CuisCore-CaseyRansberger-2020May27-11h42m-cbr.001.cs.st
Type: application/octet-stream
Size: 1148 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200527/e3a85e3c/attachment-0006.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4193-CuisCore-CaseyRansberger-2020May27-12h35m-cbr.001.cs.st
Type: application/octet-stream
Size: 5091 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200527/e3a85e3c/attachment-0007.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4194-CuisCore-CaseyRansberger-2020May27-13h40m-cbr.001.cs.st
Type: application/octet-stream
Size: 4594 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200527/e3a85e3c/attachment-0008.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4195-CuisCore-CaseyRansberger-2020May27-14h36m-cbr.001.cs.st
Type: application/octet-stream
Size: 1097 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200527/e3a85e3c/attachment-0009.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4196-CuisCore-CaseyRansberger-2020May27-15h43m-cbr.001.cs.st
Type: application/octet-stream
Size: 1816 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200527/e3a85e3c/attachment-0010.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4197-CuisCore-CaseyRansberger-2020May27-15h49m-cbr.001.cs.st
Type: application/octet-stream
Size: 305 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200527/e3a85e3c/attachment-0011.obj>