[Cuis-dev] [ChangeSet] Updates on refactorings

[Nahuel Garbezza]

Hi!

Attached is a changeset for the updated error message, plus another
suggestion from Hernan about SourceCodeInterval's #asSourceCodeInterval.

Thanks,
Nahuel

El lun., 25 de may. de 2020 a la(s) 20:02, Hernan Wilkinson via Cuis-dev (
cuis-dev at lists.cuis.st) escribió:

> Thanks Andres!
> Nahuel, could you change that error message as Andres suggests?
>
> Hernan.
>
> On Mon, May 25, 2020 at 7:47 PM Andres Valloud via Cuis-dev <
> cuis-dev at lists.cuis.st> wrote:
>
>> {variable} cannot be used as [a] temporary variable name because it is
>> defined as [an] instance variable in XX.
>>
>> On 5/25/20 15:35, Hernan Wilkinson via Cuis-dev wrote:
>> > Hi Nahuel!
>> >   thank you for the improvements and fixes. All tests are passing 💪💪
>> >   It is integrated.
>> >
>> >   I have a few minor comments:
>> > 1) I think I would change the error message "{variable} cannot be used
>> > as temporary variable name because it is an instance variable defined
>> in
>> > XX" for "{variable} cannot be used as temporary variable name because
>> it
>> > is defined as instance variable in XX"
>> > What do English native speakers think it is best?
>> > 2) When doing the extract method if you select as selector to extract
>> > the code the same as the method you are performing the extract method,
>> > it will do it but the extracted code will be lost. I think in that case
>> > it should not be a warning but an error... only in that case :-)
>> >
>> > Cheers!
>> > Hernan.
>> > On Mon, May 25, 2020 at 1:20 AM Nahuel Garbezza via Cuis-dev
>> > <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>> wrote:
>> >
>> >     Hi!
>> >
>> >     Attached is a changeset with the following changes (and their
>> >     corresponding tests):
>> >
>> >     [extract temporary / rename temporary]
>> >        - fix error message for instance variable already defined in
>> class
>> >        - allow to perform the refactoring in a debugger
>> >
>> >     [extract method]
>> >        - extracting to an existing selector (in the current class or any
>> >     superclass) now raises a warning
>> >        - allow to perform the refactoring in a debugger
>> >        - improve error messages and validation logic
>> >
>> >     [documentation]
>> >        - add a comment on RefactoringPrecondition class
>> >
>> >     Thanks,
>> >     Nahuel.
>> >     --
>> >     Cuis-dev mailing list
>> >     Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
>> >     https://lists.cuis.st/mailman/listinfo/cuis-dev
>> >
>> >
>> >
>> > --
>> > *Hernán Wilkinson
>> > Agile Software Development, Teaching & Coaching*
>> > *Phone: +54-011*-4893-2057
>> > *Twitter: @HernanWilkinson*
>> > *site: http://www.10Pines.com <http://www.10pines.com/>*
>> > Address: Alem 896, Floor 6, Buenos Aires, Argentina
>> >
>> --
>> Cuis-dev mailing list
>> Cuis-dev at lists.cuis.st
>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>>
>
>
> --
>
> *Hernán WilkinsonAgile Software Development, Teaching & Coaching*
> *Phone: +54-011*-4893-2057
> *Twitter: @HernanWilkinson*
> *site: http://www.10Pines.com <http://www.10pines.com/>*
> Address: Alem 896, Floor 6, Buenos Aires, Argentina
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st
> https://lists.cuis.st/mailman/listinfo/cuis-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200528/ad3301de/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4192-CuisCore-NahuelGarbezza-2020May27-18h58m-RNG.001.cs.st
Type: application/octet-stream
Size: 987 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200528/ad3301de/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UnsavedChangesTo-BaseImageTests-RNG.003.cs.st
Type: application/octet-stream
Size: 1116 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200528/ad3301de/attachment-0001.obj>