[Cuis-dev] Fix to ReturnNode>>isImplicitSelfReturnIn:

[Fernando Gasperi Jabalera]

Hi all,

I'm attaching a small fix to ReturnNode>>isImplicitSelfReturnIn: that I
found while making some fixes to the IntroduceNullObject refactoring I've
been working on. The problem with the previous code:

ReturnNode>>isImplicitSelfReturnIn: aMethodNode

  ^self isReturnSelf and: [ (aMethodNode encoder rawSourceRanges
includesKey: expr) not ]

is that expr is self, so it was returning false if self was referenced in
other parts of the method body.

Best,
Fernando.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20201015/780233ff/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4361-CuisCore-FernandoGasperiJabalera-2020Oct15-10h19m-FGJ.001.cs.st
Type: application/octet-stream
Size: 292 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20201015/780233ff/attachment.obj>