[Cuis-dev] [ChangeSet] TextParagraphMorph

Juan Vuletich JuanVuletich at zoho.com
Thu Dec 2 12:43:29 PST 2021


On 12/2/2021 5:34 AM, Hilaire Fernandes via Cuis-dev wrote:
> Le 30/11/2021 à 19:51, Juan Vuletich a écrit :
>>
>> The first version I tried did that, and also avoided the last line 
>> even if just the white space below the glyphs was at risk. But when 
>> resizing the example, it looked like it was removing the last line 
>> "too early", when it could still be displayed perfectly.
>>
>> The version I pushed only avoids the last line only if the baseline 
>> (the bottom of regular glyphs) would lie outside bounds. This means 
>> that occasionally glyph descenders could go outside bounds. That's 
>> why I kept the "border over text" code. Anyway, the difference is 
>> minimal, and the inherited version would also be ok.
>
> Ok fine.
>
> I observe two annoyances when the TextParagraphMorph has a border and 
> it is added to a Scroller:
>
>     * The scroller does not scroll to the last line. Here you see
>       after '...to a line,' the next line is missing. The issue goes
>       away when you set the TextParagaphMorph's borderWidth to 0.
>     * The ScrollBar is too too small to show the up and down arrows,
>       in that circumstance it will be super cool to not add the
>       up/down or left/right arrows.
>
> I try to fix the former issues, without success. The later one 
> requires more work
>
> Hilaire
>
> -- 
> GNU Dr. Geo
> http://drgeo.eu
> http://blog.drgeo.eu

Both fixed now. Updates @ GitHub. Please test.

Thanks for reporting!

Cheers,

-- 
Juan Vuletich
www.cuis-smalltalk.org
https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev
https://github.com/jvuletich
https://www.linkedin.com/in/juan-vuletich-75611b3
@JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20211202/3b1c87bc/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 10216 bytes
Desc: not available
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20211202/3b1c87bc/attachment.png>


More information about the Cuis-dev mailing list