[Cuis-dev] pull req. A little addition to package OSProcess.

[David T. Lewis]

Thanks Nicola,

I have made the updates, and I did one more commit to GitHub.

Updating the Monticello repo from GitHub was not hard, and the
repositories are in sync now.

Thanks for attaching the changes, it is helpful for me (but
not required).

Dave

On Sat, Oct 16, 2021 at 07:20:34PM +0200, Nicola Mingotti via Cuis-dev wrote:
> 
> Hi Dave,
> 
> I still have the fileout in the disk, I attach it here so you can save 
> some time.
> 
> One day you should tell me the way to keep in sync with monticello 
> (Squeak, Pharo).
> 
> I have the same problem with the Regex package. I saw people has added 
> things
> in Squeak but i don't know well how to diff beween our package system 
> and Monticello.
> it is not urgent, another weekend !
> 
> 
> bye
> Nicola
> 
> 
> On 10/16/21 19:12, David T. Lewis via Cuis-dev wrote:
> >Hi Nicola,
> >
> >The PR is fine but if you could also send the fileout that would be helpful
> >for me. There is an upstream Monticello repo for OSProcess that I want to
> >keep in sync, so it's a bit easier for me if I can apply it there first.
> >
> >But I'm going to try doing it the other way around this time and see
> >how well it works. I'll merge your PR first and then update the Monticello
> >repo.
> >
> >Thanks for the contribution, it's a good idea to add this #exitCode method.
> >
> >Dave
> >
> >On Sat, Oct 16, 2021 at 04:53:03PM +0200, Nicola Mingotti via Cuis-dev 
> >wrote:
> >>Hi Juan, Dave, guys,
> >>
> >>I don't know what to do in this case, I don't think i need to post the
> >>fileout, do i?
> >>
> >>The pull request is here:
> >>https://github.com/Cuis-Smalltalk/OSProcess/pull/2
> >>
> >>The merge request adds a convenience method to check exit code in forked
> >>processes in Unix like systems,
> >>a test method is added as well.
> >>
> >>---- Example -----
> >>out _ OSProcess waitForCommand: ' sh -c "exit 33" '.
> >>out exitCode .???? "=> 33 "
> >>--------------------
> >>
> >>bye
> >>Nicola
> >>-- 
> >>Cuis-dev mailing list
> >>Cuis-dev at lists.cuis.st
> >>https://lists.cuis.st/mailman/listinfo/cuis-dev


> -- 
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st
> https://lists.cuis.st/mailman/listinfo/cuis-dev