[Cuis-dev] Compression and SqueakCompatibility packages fail to load

[Mariano Montone]

👍

Now SqueakCompatibility needs a fix too.😯 It tries to extend 
StandardFileStream, which is not available anymore.

I don't know how to fix it myself because I don't know about that class 
and why it was removed.


     Mariano

El 31/10/22 a las 12:25, Juan Vuletich escribió:
> Hi Mariano,
>
> Nah. Just updated the packages and fixes them.
>
> If client code still thinks it is ok to do `aString compress` or 
> `aString decompress`, they will still get walkbacks. What is 
> compressed is bytes, not Strings. So, if further problems arise, let's 
> discuss and solve them.
>
> Cheers,
>
> On 10/30/2022 10:43 AM, Mariano Montone via Cuis-dev wrote:
>> Hi,
>>
>> I would apply your "bad" solution, as lots of packages depend on 
>> Compression right now and can't be used in the new image.
>>
>> Perhaps then create an issue in Cuis issue tracker with the task of 
>> improving/making right Compression for later.
>>
>> Mariano
>>
>> El 29/10/22 a las 21:21, Juan Vuletich escribió:
>>> Hi Folks,
>>>
>>> I could load it and make the tests pass. For that:
>>> - I edited the package file and changed references to 
>>> StandardFileStream and FileStream to UniFileStream. Trivial.
>>> - added #byteAt: and #byteAt:put: to String. This doesn't look like 
>>> a good idea.
>>> - added #asByteString to the 'Hello World' literal in the test. 
>>> Neither this looks right.
>>>
>>> But this is most likely not a good solution.
>>>
>>> It seems that Compression is making the assumption that Strings are 
>>> made of Byte characters. I don't know the compression algorithms in 
>>> detail, or what is the standard way to deal with UTF-8 content in 
>>> compression. Most likely it is byte by byte, right? If so, 
>>> Compression should be adapted to work on ByteArrays only, and claim 
>>> no knowledge of how Strings are encoded.
>>>
>>> If any of you can take a deeper look into this, it would be a great 
>>> service to the community.
>>>
>>> Thanks,
>>>
>>> On 10/29/2022 10:17 AM, Gerald Klix via Cuis-dev wrote:
>>>> Thanks for testing, that saved me a lot of work.
>>>> Cuis without the Compression package is rather useless to me.
>>>>
>>>>
>>>> Best Regards,
>>>>
>>>> Gerald
>>>>
>>>>
>>>>
>>>> On 29.10.22 13:29, Mariano Montone via Cuis-dev wrote:
>>>>> Hi,
>>>>>
>>>>> Compression and SqueakCompatibility packages fail to load in 
>>>>> latest image because FileStream and StandardFileStream classes are 
>>>>> not available anymore, and they want to add extensions to those 
>>>>> classes.
>>>>>
>>>>> Have a fix?
>>>>>
>>>>> Thanks,
>>>>>
>>>>>      Mariano
>>>>>
>>>>
>>>
>>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20221031/e7204014/attachment.htm>