[Cuis-dev] Theme customization ... browser buttons

[Gerald Klix]

Hi Alexandre,

Subclassing BrowserWindow and PluggableButtonMorph is one possible solution.

The other solution is to provide a proper change set for the base image,
containing the added preference and the changed PluggableButtonMorph
code. I presume that this is a rather simple change, meaning it does not
create a big review effort for Juan, therefore he might accept such a 
change.
I am strongly in favor of such a solution, because I want a better contrast
of the buttons wrt. to the window background.

While you are at it, you may also try to unify the code that calculates
the color of the browser's inheritance button and the code that calculates
the color of this very button's balloon help. The balloon help code
is a rather bad hack (of mine).


HTH and Best Regards,

Gerald


On 3/17/23 2:23 PM, Alexandre Rousseau via Cuis-dev wrote:
> Hi.
>
> I'm subclassing ClassicTheme to define my own theme, drawing examples from
> ClassicTheme and its parent class (Theme).
>
> I now want to customize the colors of Browser buttons (instances of
> PluggableButtonMorph), i.e., I do not want their background color to be
> taken from the defaultWindowColor theme variable, but rather from a new
> one, say, defaultButtonBackgroundColor.
>
> Does this imply that I have to subclass Browser and PluggableButtonMorph,
> or is there a more expedient solution?
>
> Thanks!
>
> [image: Screenshot 2023-03-17 at 9.16.26 AM.png]
>
>