[Cuis-dev] [FIX] Re: BMP Reader broken

[Juan Vuletich]

Hi Vanessa,

On 3/16/2024 11:25 PM, Vanessa Freudenberg via Cuis-dev wrote:
> Hmm, curious. While the fix does make it work, it doesn't explain why 
> it worked on SqueakJS without the fix.
>
> I think the root cause might be that the behavior of 
> "next:into:startingAt:" changed. It has a time stamp of "jmv 1/8/2024" .
>
> Oh yes. Ooops. When I said it works on SqueakJS, I was actually on a 
> 6.2 image. In a 6.3 image I get the same error.
>
> So while my fix works, maybe it would be better to fix the regression 
> in "next:into:startingAt:" instead.
>
> Vanessa

Thank you so much! This is the real root cause of the problem. Your help 
let me jump straight into it. That method was added to the system by me 
on that date, but it shouldn't be there. Removing it fixes the issue.

Still. I also included your changeset, because it avoids iterating over 
each byte and calling #next, so it even with the root bug fixed, it 
helps as a performance improvement.

Thanks all for finding and investigating this problem!

Cheers,

-- 
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich