[Cuis-dev] New Feature! - MultiSelect
Juan Vuletich
juan at cuis.st
Fri Nov 28 11:22:10 PST 2025
Hi Folks,
I've finally spent a couple of hours reviewing this. I like the idea,
and it seems to work. Some comments:
- #buildMorphicSingleMessageList uses a PluggableListMorphOfMany and is
essentially the same as #buildMorphicMultipleMessageList.
- #buildMorphicMultipleMessageList has no senders at all
- It looks like the intention was to allow the user to choose between a
single-selection and a multi-selection method list, but no such
preference is provided
- #turnMouseButton1Into2 is deactivated, but some people may be using it
with a single-button mouse. I agree that this clashes with the common
gestures for multiple selection, but removing this needs consensus in
the community, or an alternative that keeps support for 1-button mice
working.
- #OnShiftPressedSelectFrom:To: has both keywords starting in uppercase.
This is not common Smalltalk style.
- The current behavior of PluggableListMorphOfMany is to allow using
click to select and to deselect elements. This is useful, for instance
in the MethodSetWindow hierarchy. Is disabling this needed?
I think this code needs some more work, and some consensus on the
changes that affect existing behavior.
Thanks,
On 2025-11-25 11:59 AM, alan wharton via Cuis-dev wrote:
> Hello!
> We've implemented together with Nicolas Halperin the possibility to
> select multiple messages, and make operations like moving to a
> different category, various refactors or running a test suite.
> One important thing to notice is that we modified a method that seemed
> that it had no use when browsing its senders:
> turnMouseButton1Into2
> "Answer true if modifier keys are such that button 1 should be
> considered as button 2.
> ctrl - click -> right click
> "
>
> "(self controlKeyPressed and: [self shiftPressed not]) ifTrue: [ ^
> true ]."
> ^ false
>
> We wanted to have a multipleSelect with no drag and for that we used
> the controlKey, and noticed this method was impeding us from doing that.
>
> Hope you take a look!
> Alan Wharton
> Nicolas Halperin
>
>
>
>
--
Juan Vuletich
www.cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20251128/c6d723ef/attachment.htm>
More information about the Cuis-dev
mailing list