[Cuis-dev] Changesets stamps

[Hernan Wilkinson]

Hi Mariano,
 I just uploaded a fix for this.
 The reason we are saving the timestamp for class definition is to make
homogeneous how changes are saved in the changes file. There are also new
tools we are building that use that info.
 A Method has a direct relationship with its stamp but a class do not, that
it is why it was regenerated each time when saving a package. To avoid that
we should make all classes know its stamp but that is a structure change in
the metamodel that I think does not pay off, at least by now.

 Anyhow, this fix does not save class definition stamps anymore.

Cheers!
Hernan.

On Thu, Nov 7, 2019 at 9:01 PM Mariano Montone <marianomontone at gmail.com>
wrote:

> I think ClassDescription>>definitionPreamble may be the problem:
>
> -----------------------
> definitionPreamble
>
>         ^'classDefinition: ', self name printString, ' category: ', self
> category printString, Utilities changeStampField
> -----------------------
>
> Utilities changeStampField may be overwriting the stamp, regardless of
> if the class changed or not.
>
> Previous versions don't print stamps at all (which I'm not sure makes
> sense either).
>
> Mariano
>
> El 5/11/19 a las 21:53, Hernan Wilkinson escribió:
> > Hi Mariano,
> >  I refactor some parts of the changes system a couple of days ago, I may
> > have introduce a bug.
> >  Let me check that tomorow and let you know
> >
> > Hernan
> >
> > On Tue, 5 Nov 2019 at 21:36 Mariano Montone via Cuis-dev
> > <cuis-dev at lists.cuis.st <mailto:cuis-dev at lists.cuis.st>> wrote:
> >
> >     Hello.
> >
> >     I've noticed that all the stamps for all classes and methods of a
> >     package are updated when I save a package, even the classes and
> methods
> >     I have not changed . And so I get very big and unnecessary diffs in
> git
> >     commits (from my point of view).
> >
> >     Like here:
> >
> https://bitbucket.org/mmontone/mold/commits/ab0ff86f10d7e46f55abb93889efec4f0ea79d68#chg-GenericBrowser.pck.st
> >
> >     Lots of stamp changes, although I didn't change the classes and
> methods
> >     code itself.
> >
> >     Am I doing something wrong? Or it is the way things are supposed to
> >     work?
> >
> >     Thanks!
> >
> >     Mariano
> >     --
> >     Cuis-dev mailing list
> >     Cuis-dev at lists.cuis.st <mailto:Cuis-dev at lists.cuis.st>
> >     https://lists.cuis.st/mailman/listinfo/cuis-dev
> >
> > --
> > Sent from a fat finger unaware device
>
>

-- 

*Hernán WilkinsonAgile Software Development, Teaching & Coaching*
*Phone: +54-011*-4893-2057
*Twitter: @HernanWilkinson*
*site: http://www.10Pines.com <http://www.10pines.com/>*
Address: Alem 896, Floor 6, Buenos Aires, Argentina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20191109/01fdd050/attachment.htm>