[Cuis-dev] Question re: recent updates (4342)

Tue Aug 18 20:28:55 PDT 2020

Juan,

Much better, thanks.

FYI, in #drawWorldComputeDamage:repair:rootMorphs:rootMorphsDamage: it is
possible for morphBounds in 'r intersect: morphBounds' to be nil.  Not sure
yet if this is something in my code that still needs to be updated for the
latest changes or if I'm hitting a case you hadn't anticipated.  I'm
mentioning it because I'm wondering if there should be a
#displayFullBoundsOrBogus (i.e. to be used by
#drawWorldComputeDamage:repair:rootMorphs:rootMorphsDamage:) or should this
case just not ever be happening?

Thanks,
Phil

On Tue, Aug 18, 2020 at 3:58 PM Juan Vuletich via Cuis-dev <
cuis-dev at lists.cuis.st> wrote:

> I see. Please try the fixes I just pushed. Note that I pushed a modified
> version of #4352.
>
> Thanks,
>
> On 8/18/2020 3:33 PM, Phil B via Cuis-dev wrote:
>
> Easier to show than describe: https://www.youtube.com/watch?v=E8lwDvqo0vo
> (screen damage both after the save and after restarting the image)
>
> On Tue, Aug 18, 2020 at 6:27 AM Juan Vuletich <juan at jvuletich.org> wrote:
>
>> On 8/18/2020 12:28 AM, Phil B via Cuis-dev wrote:
>>
>> OK, sorry about this... I was hoping that getting to the latest updates
>> would fix a display damage update bug that looks like it was introduced
>> sometime after 4249, but it didn't.  Thinking I might have some other issue
>> going on with my image, I tried starting with the 4342 image from the repo,
>> updated it to 4352, then save and quit.  When I restart the image, the
>> entire screen is white until I start forcing display damage (bring up the
>> world menu, move windows around etc)... do you see this issue?   I'm
>> running sqcogspur64linuxht-20200219 in case it matters.
>>
>> Thanks,
>> Phil
>>
>>
>> Does the problem persist if you save as new version? If not, just do it.
>>
>> Des the latest image from GitHub (#4342) have the problem? If so, please
>> provide the most detailed steps to reproduce you can. Think that it's all I
>> have to start understanding the problem.
>>
>> Can the problem be reproduced again once the image is running? If so,
>> again, detailed steps to reproduce, please.
>>
>> Thanks,
>>
>>
>> On Mon, Aug 17, 2020 at 11:10 PM Phil B <pbpublist at gmail.com> wrote:
>>
>>> Juan,
>>>
>>> Ahh!  That was the clarity I needed... it never occurred to me that the
>>> issue would be that we were saving the image using subtly different methods
>>> and that would result in the different behavior.  Now I get it and it's
>>> working.
>>>
>>> Thanks,
>>> Phil
>>>
>>> On Mon, Aug 17, 2020 at 10:04 PM Juan Vuletich <JuanVuletich at zoho.com>
>>> wrote:
>>>
>>>> On 8/17/2020 9:18 PM, Phil B via Cuis-dev wrote:
>>>>
>>>> Juan,
>>>>
>>>> On Mon, Aug 17, 2020 at 7:06 PM Juan Vuletich <juan at jvuletich.org>
>>>> wrote:
>>>>
>>>>> On 8/17/2020 2:36 PM, Phil B via Cuis-dev wrote:
>>>>>
>>>>> I tried updating straight through from 4322->4351 (i.e. ignoring the
>>>>> message on 4342 saying I need to restart, since that would be the only way
>>>>> to avoid hanging after 4342)
>>>>>
>>>>>
>>>>> No, the message says you "need to restart the image update".
>>>>> Transcript shows: 'Please restart [Install New Updates].'
>>>>>
>>>>
>>>> Right, but the issue is if I save and quit, the image hangs on
>>>> restart.  I didn't expect it to work, but even with your revised 4342, I'm
>>>> still stuck trying to restart after 4342 is applied.
>>>>
>>>>
>>>>>
>>>>> but it still white screens for me on restart.  Does the world state
>>>>> fix need to be applied either right before or right after 4342? (I'm OK
>>>>> with a manual step if fixing it in the update changesets isn't feasible, I
>>>>> just need to know what the fix is and when to apply it)
>>>>>
>>>>>
>>>>> The fixes I did were to add a Delay wait in #4342, and the new #4350.
>>>>> But there is no need to apply them by hand. Just restart the update install.
>>>>>
>>>>> So, don't exit the image. Just do World / Changes... / Install New
>>>>> Updates. That should load the new updates, up to #4351. After that, saving
>>>>> and restarting should work.
>>>>>
>>>>
>>>> You see the contradiction, right?  If I'm starting from 4322, and per
>>>> your previous statement, I *must* save and quit after 4342 so I can
>>>> restart.  However, at that point things hang so I can't apply anything
>>>> after that.  I was going straight through thinking 'this is the only way I
>>>> can see to accomplish what Juan's saying... despite the update telling me
>>>> something different'   So I've tried both restarting after 4342 as well as
>>>> going straight through: neither results in a working image for me.
>>>>
>>>>
>>>>
>>>> No contradiction. Just misunderstanding. I'm doing it again right now:
>>>>
>>>> - Start the image you provided, (previously added a copy of an updated
>>>> CoreUpdates/ folder).
>>>> - Open the World menu / Changes... / Install New Updates
>>>> - Enter initials: jmv. Confirm it's me. Accept the warning.
>>>> - Wait a sec until update #4342 is installed, and Transcript says
>>>> "Please restart [Install New Updates]."
>>>> - Open the World menu / Changes... / Install New Updates
>>>> - Updates up to 4351 get installed.
>>>> - Save as New Version.
>>>> - Quit
>>>>
>>>> Saved image starts without problem.
>>>>
>>>> I found that if instead of Save as New Version, you just Save and Quit,
>>>> the resulting image can't start. I just added another update to GitHub for
>>>> that case.
>>>>
>>>> Please try again now.
>>>>
>>>> Thanks,
>>>>
>>>> --
>>>> Juan Vuletichwww.cuis-smalltalk.orghttps://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Devhttps://github.com/jvuletichhttps://www.linkedin.com/in/juan-vuletich-75611b3
>>>> @JuanVuletich
>>>>
>>>>
>>
>> --
>> Juan Vuletichwww.cuis-smalltalk.orghttps://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Devhttps://github.com/jvuletichhttps://www.linkedin.com/in/juan-vuletich-75611b3
>> @JuanVuletich
>>
>>
>
> --
> Juan Vuletichwww.cuis-smalltalk.orghttps://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Devhttps://github.com/jvuletichhttps://www.linkedin.com/in/juan-vuletich-75611b3
> @JuanVuletich
>
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st
> https://lists.cuis.st/mailman/listinfo/cuis-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20200818/23fc55fd/attachment-0001.htm>