[Cuis-dev] user.changes files

[Bernhard Pieber]

Hi everyone,

Ignore my mail. I was wrong. Obviously, it was already too late yesterday. Only the "End fileIn of“ banner is written there. Now the question is: Is this intended?

fileInAnnouncing: announcement
	"This is special for reading expressions from text that has been formatted
	with exclamation delimitors. The expressions are read and passed to the
	Compiler. Put up a progress report with the given announcement as the title."

	Utilities logsUserChanges: false.

	announcement
		displayProgressAt: Sensor mousePoint
		from: 0
		to: self size
		during: [ :barBlock | self fileInInformingTo: barBlock ].

	"Note:  The main purpose of this banner is to flush the changes file."
	Utilities logsUserChanges: true.
	Smalltalk logChange: '----End fileIn of ' , self name , '----'.

Should the comment about flushing the changes file apply to both, the .changes and the .user.changes file? Looking at the code the forceToDisk is done for the .changes file.

Cheers,
Bernhard


> Am 26.03.2023 um 21:56 schrieb Bernhard Pieber via Cuis-dev <cuis-dev at lists.cuis.st>:
>
> I just saw that the change set installed with ChangeSet installNewUpdates end up in the .user.changes. As they are filed in shouldn’t they just go to the .changes file?
>
> Cheers,
> Bernhard
>
>
>> Am 26.03.2023 um 16:18 schrieb Bernhard Pieber via Cuis-dev <cuis-dev at lists.cuis.st>:
>>
>> Hi everyone,
>>
>> I just read up on the purpose of the user.changes file because I had not understood them properly. In case others are wondering as well I found these mails most informative:
>>
>> Thread New User Changes log file
>> http://cuis-smalltalk.org/pipermail/cuis-dev_cuis-smalltalk.org/2018-July/003755.html
>>
>> Thread Changes not recoverable
>> https://lists.cuis.st/mailman/archives/cuis-dev/2020-December/002545.html
>> https://lists.cuis.st/mailman/archives/cuis-dev/2020-December/002552.html
>> https://lists.cuis.st/mailman/archives/cuis-dev/2020-December/002556.html
>>
>> I learned that code that you file in only goes to the changes file. Manual code changes and do-its are written to the .user.changes file and the .changes file. This makes recovery easier. However, in case you don’t save your image all changes since the last image save remain only in the user.changes file. So the user.changes file are not totally redundant. If you just delete all of them, you might not be able to recover all code changes you did.
>>
>> If the amount of user.changes file bothers you you can use the Preference #autoNumberUserChanges to have just one.
>>
>> If I read the code correctly if file-in fails user changes might stop to be written. The attached change set should fix that.
>>
>> Cheers,
>> Bernhard
>>
>> --
>> Cuis-dev mailing list
>> Cuis-dev at lists.cuis.st
>> https://lists.cuis.st/mailman/listinfo/cuis-dev
>> <5718-ensure-logUserChanges-is-reset-BernhardPieber-2023Mar26-15h48m-bp.001.cs.st>
>
>
> --
> Cuis-dev mailing list
> Cuis-dev at lists.cuis.st
> https://lists.cuis.st/mailman/listinfo/cuis-dev