[Cuis-dev] A few comments on the new box hierarchy

[Juan Vuletich]

Hi Hilaire,

On 9/11/2024 2:31 PM, Hilaire Fernandes via Cuis-dev wrote:
>
> Hi folks,.
>
> The video of our discussion today is referenced in the archive section 
> of our community page http://cuis.st/community
>

Cool!

> I have few comments, observation, questions and requests.
>
> The BoxMorph seems to have only one direct subclass 
> (BorderedBoxMorph), but the idea is to open to possibility for 
> subclasses to only have extent and no border, right?  I open a 
> discussion about that several days ago. Is it because of that?
>

Yes. In addition to that, I've just added ColoredBoxMorph between 
BoxMorph and BorderedBoxMorph and moved ivar 'color' there. There are 
several classes that have color, but no border or padding.

> Why BoxedMorph not a subclass of BoxMorph?
>

Because it is easier to create the new hierarchy, then move all 
subclasses of BoxedMorph there, and finally remove BoxedMorph. Will take 
a few days to get there.

> About the name BoxedMorph and BorderedBoxMorph have the same meaning 
> in their names. What about renaming BorderedBoxMoprh to PaddedBoxMorph.
>
> If we merge back together BoxMorph and BoxedMorph we will avoid the 
> code duplication we have between BoxedMorph and BordederdBoxMorph 
> (related to my first observation)
>

No, BoxedMorph will be removed.

> It will nice to rephrase the comments at the end of the BoxedMorph and 
> BoxMorph. It still don't understand the sentences
>
> BorderedBoxMorph class comment writes about BorderedRectMorph...
>

I'll take a look

> Thanks for this nice improvement on layout
>
> Hilaire
>
> -- 
> GNU Dr. Geo
> http://gnu.org/s/dr-geo/
> http://gnu-drgeo.blogspot.com/

Thanks!

-- 
Juan Vuletich
cuis.st
github.com/jvuletich
researchgate.net/profile/Juan-Vuletich
independent.academia.edu/JuanVuletich
patents.justia.com/inventor/juan-manuel-vuletich
linkedin.com/in/juan-vuletich-75611b3
twitter.com/JuanVuletich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cuis.st/mailman/archives/cuis-dev/attachments/20240911/4e3cc41e/attachment.htm>